[FXC-5244] fix(): Added validator for write_single_file to surface output#1756
Merged
piotrkluba merged 2 commits intorelease-candidate/25.7from Feb 4, 2026
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
benflexcompute
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ticket: https://flow360.atlassian.net/browse/FXC-5244
Note
Low Risk
Small, localized validation change that only affects parameter construction/validation for
SurfaceOutputand is covered by new/updated tests.Overview
Adds an after model validator on
SurfaceOutputto enforce thatwrite_single_fileis only valid for Tecplot output: it now raises foroutput_format="paraview"and warns (but allows) foroutput_format="both".Extends test coverage with a new validator test and updates several existing fixtures/tests to explicitly set
output_format="tecplot"whenwrite_single_file=True.Written by Cursor Bugbot for commit 195e6b9. This will update automatically on new commits. Configure here.