Skip to content

[FXC-5244] fix(): Added validator for write_single_file to surface output#1756

Merged
piotrkluba merged 2 commits intorelease-candidate/25.7from
piotr/add-validation-surface-out
Feb 4, 2026
Merged

[FXC-5244] fix(): Added validator for write_single_file to surface output#1756
piotrkluba merged 2 commits intorelease-candidate/25.7from
piotr/add-validation-surface-out

Conversation

@piotrkluba
Copy link
Collaborator

@piotrkluba piotrkluba commented Jan 30, 2026

ticket: https://flow360.atlassian.net/browse/FXC-5244


Note

Low Risk
Small, localized validation change that only affects parameter construction/validation for SurfaceOutput and is covered by new/updated tests.

Overview
Adds an after model validator on SurfaceOutput to enforce that write_single_file is only valid for Tecplot output: it now raises for output_format="paraview" and warns (but allows) for output_format="both".

Extends test coverage with a new validator test and updates several existing fixtures/tests to explicitly set output_format="tecplot" when write_single_file=True.

Written by Cursor Bugbot for commit 195e6b9. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@piotrkluba piotrkluba merged commit 2777bde into release-candidate/25.7 Feb 4, 2026
16 checks passed
@piotrkluba piotrkluba deleted the piotr/add-validation-surface-out branch February 4, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants